fix(ui5-select): prevent crash on ArrowUp/Down when value matches no option #12094
+60
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgogov
force-pushed
the
select-keyboard-navigation-fix
branch
from
1e97c10 to
68c4f46
Compare
NakataCode
requested changes
Aug 15, 2025
| </Select> | ||
| ); | ||
|
|
||
| cy.get("#sel-down") |
There was a problem hiding this comment.
You can remove the id attribute from the mount and use [ui5-select] selector instead of #sel-down throughout the test
| </Select> | ||
| ); | ||
|
|
||
| cy.get("#sel-up") |
There was a problem hiding this comment.
Same here in this test, you can use [custom-tag] instead of the id(and remove the id from the mount)
| ); | ||
|
|
||
| cy.get("#sel-down") | ||
| .should("have.attr", "value", "missing") |
There was a problem hiding this comment.
For consistency, consider using have.prop for the value assertion since you're testing the component's value property:
.should("have.prop", "value", "missing")| ); | ||
|
|
||
| cy.get("#sel-up") | ||
| .should("have.attr", "value", "missing") |
There was a problem hiding this comment.
Same here, you can change it to have.prop for consistency
…option If select's value property is set to a string that doesn’t match any option, nothing is selected (selectedIndex = -1). When you press ArrowUp or ArrowDown, _changeSelectedItem tries to use invalid indices, which causes it to access undefined and crash at runtime. Fixes: #12093
kgogov
force-pushed
the
select-keyboard-navigation-fix
branch
from
68c4f46 to
c6ce6f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If select's
valueproperty is set to a string that doesn’t match any option, nothing is selected(selectedIndex = -1). When you press ArrowUp or ArrowDown,_changeSelectedItemtries to use invalid indices, which causes it to accessundefinedand crash at runtime.Fixes: #12093